Adding support for 1-based index with the @index_1 psuedo variable #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find an issue for handlebars.java, but this is an extremely popular feature request for handlebars.js: |
|
@eliw42 looks good! @andersonimes do you mean the +1 index? or the math helper? |
|
+1 index. Math helper would be great too.
|
jknack
added a commit
that referenced
this pull request
Jan 23, 2015
Adding support for 1-based index with the @index_1 psuedo variable
|
Thanks @jknack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm happy to rename the psuedo variable, but this is a feature that is sorely missed. I went with this syntax Ember uses: http://mozmonkey.com/2014/03/ember-getting-the-index-in-each-loops/. I like this much more than other solutions that involve creating a math helper. Let me know what you think!
Eli