Update the default constructor of CompareState to set a more useful e…

…mpty state that won't segfault.
jkoritzinsky · Jul 14, 2023 · 28b3fd5 · 28b3fd5
1 parent 3a37f90
commit 28b3fd5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/coreclr/vm/siginfo.cpp b/src/coreclr/vm/siginfo.cpp
@@ -3662,8 +3662,7 @@ MetaSig::CompareElementType(
     }
     CONTRACTL_END
 
-    TokenPairList tempList { nullptr };
-    CompareState temp{ &tempList };
+    CompareState temp{  };
     if (state == NULL)
         state = &temp;
 

diff --git a/src/coreclr/vm/siginfo.hpp b/src/coreclr/vm/siginfo.hpp
@@ -957,7 +957,10 @@ class MetaSig
             // be compared.
             bool IgnoreCustomModifiers;
 
-            CompareState() = default;
+            CompareState()
+                : Visited{ nullptr }
+                , IgnoreCustomModifiers{ false }
+            { }
 
             CompareState(TokenPairList* list)
                 : Visited{ list }