Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default scopes based on provider #58

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Add default scopes based on provider #58

merged 1 commit into from
Oct 29, 2023

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9385d1d) 77.85% compared to head (39d7184) 77.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   77.85%   77.34%   -0.51%     
==========================================
  Files          20       20              
  Lines        1314     1320       +6     
==========================================
- Hits         1023     1021       -2     
- Misses        240      246       +6     
- Partials       51       53       +2     
Files Coverage Δ
internal/config/config.go 96.19% <100.00%> (ø)
internal/oauth2/provider.go 79.81% <100.00%> (+0.76%) ⬆️
internal/oauth2/providers/generic/main.go 50.00% <0.00%> (-16.67%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit 874b0b3 into main Oct 29, 2023
7 checks passed
@jkroepke jkroepke deleted the scopes branch October 29, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant