Change error code on sampler count mismatch to invalid_gltf #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error as it stands is a little misleading: it's the only case where we emit an error like this when the sizes aren't equal, so it can hit when the output count is *larger* (so there's technically enough data, but the glTF file is still invalid per spec / per Khronos validator). In other cases where a size mismatches like this we currently emit invalid_gltf so this seems to make more sense.
|
The build error was unrelated to the PR (glTF-Sample-Models changed from master to main) but it was just one line to fix so I fixed it in this PR as it would need that fix to become green anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error as it stands is a little misleading: it's the only case where we emit an error like this when the sizes aren't equal, so it can hit when the output count is larger (so there's technically enough data, but the glTF file is still invalid per spec / per Khronos validator). In other cases where a size mismatches like this we currently emit invalid_gltf so this seems to make more sense.