Skip to content

Commit

Permalink
build: don't use lint-ci on Travis
Browse files Browse the repository at this point in the history
The `lint-ci` Makefile target differs from `lint` in that it writes to
a tap file and not stdout and also stops execution when an error is
found (e.g. if JavaScript linting fails the C++ and docs linting are
not run).

The switch to `lint-ci` was to enable Python linting. Revert to `lint`
and add the `lint-py` target.

PR-URL: nodejs#27062
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richardlau committed Apr 5, 2019
1 parent 2f1ed5c commit af03de4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
install:
- make lint-py-build || true
script:
- NODE=$(which node) make lint-ci
- NODE=$(which node) make lint lint-py

- name: "Compile V8"
language: cpp
Expand Down

0 comments on commit af03de4

Please sign in to comment.