perf/lazy-monkey-patch #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlalmes
commented
Aug 22, 2022
|
I believe this is safe, but would be great if anyone could code review/share thoughts on this PR before I merge 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements
These changes really only effect
nextjsbecause the entire handler setup will be executed on and every request.voidinputs is lazy and will only happen once a procedure is called (instead of all procedures being monkey patched upfront).generateOpenApiDocumenton handler setup inproduction. This means we no longer validate yourrouterconforms to ourOpenApiRouterspec, we just assume this to be true.