Skip to content

Commit

Permalink
iov_iter: Map the page later in copy_page_from_iter_atomic()
Browse files Browse the repository at this point in the history
Remove a couple of calls to kunmap_atomic() in the rare error cases.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Kent Overstreet <kent.overstreet@linux.dev>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
  • Loading branch information
Matthew Wilcox (Oracle) committed Jul 24, 2023
1 parent 6eaae19 commit f7f9a0c
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions lib/iov_iter.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,20 +569,20 @@ EXPORT_SYMBOL(iov_iter_zero);
size_t copy_page_from_iter_atomic(struct page *page, unsigned offset, size_t bytes,
struct iov_iter *i)
{
char *kaddr = kmap_atomic(page), *p = kaddr + offset;
if (!page_copy_sane(page, offset, bytes)) {
kunmap_atomic(kaddr);
char *p;

if (!page_copy_sane(page, offset, bytes))
return 0;
}
if (WARN_ON_ONCE(!i->data_source)) {
kunmap_atomic(kaddr);
if (WARN_ON_ONCE(!i->data_source))
return 0;
}

p = kmap_atomic(page) + offset;
iterate_and_advance(i, bytes, base, len, off,
copyin(p + off, base, len),
memcpy_from_iter(i, p + off, base, len)
)
kunmap_atomic(kaddr);
kunmap_atomic(p);

return bytes;
}
EXPORT_SYMBOL(copy_page_from_iter_atomic);
Expand Down

0 comments on commit f7f9a0c

Please sign in to comment.