Fix lint.

jlewi · May 3, 2024 · 8fd8116 · 8fd8116
1 parent de1de31
commit 8fd8116
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/app/pkg/agent/agent_test.go b/app/pkg/agent/agent_test.go
@@ -5,6 +5,8 @@ import (
 	"os"
 	"testing"
 
+	"github.com/jlewi/foyle/app/api"
+
 	"github.com/jlewi/foyle/app/pkg/config"
 	"github.com/jlewi/foyle/app/pkg/oai"
 	"github.com/jlewi/foyle/protos/go/foyle/v1alpha1"
@@ -71,7 +73,7 @@ func Test_Generate(t *testing.T) {
 		t.Fatalf("Error creating OpenAI client; %v", err)
 	}
 
-	cfg.Agent.RAG = &config.RAGConfig{
+	cfg.Agent.RAG = &api.RAGConfig{
 		MaxResults: 3,
 	}
 	cfg.Agent.RAG.Enabled = true

diff --git a/app/pkg/eval/evaluator.go b/app/pkg/eval/evaluator.go
@@ -2,7 +2,6 @@ package eval
 
 import (
 	"context"
-	"fmt"
 	"os"
 	"path/filepath"
 
@@ -351,7 +350,7 @@ func (e *Evaluator) updateGoogleSheet(ctx context.Context, experiment api.Experi
 	}
 
 	// Prepare the value range to write
-	writeRange := fmt.Sprintf("%s", sheetName)
+	writeRange := sheetName
 	values := [][]interface{}{{"id", "prompt", "actual", "expected", "distance"}}
 
 	iter, err := db.NewIterWithContext(ctx, nil)
@@ -443,7 +442,7 @@ func (e *Evaluator) findUnloadedFiles(ctx context.Context, db *pebble.DB, files
 // listEvalFiles returns a list of the all the Foyle files in the eval directory.
 func (e *Evaluator) listEvalFiles(ctx context.Context, evalDir string) ([]string, error) {
 	examples := make([]string, 0, 100)
-	filepath.Walk(evalDir, func(path string, info os.FileInfo, err error) error {
+	err := filepath.Walk(evalDir, func(path string, info os.FileInfo, err error) error {
 		if info.IsDir() {
 			return nil
 		}
@@ -456,7 +455,7 @@ func (e *Evaluator) listEvalFiles(ctx context.Context, evalDir string) ([]string
 		return nil
 	})
 
-	return examples, nil
+	return examples, err
 }
 
 // loadFoyleFiles loads a bunch of Foyle files representing evaluation data and converts them into example