-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update retraining to work with RunMe #110
Comments
Needed ChangesWe need to update the Logs Analyzer to process the RunMe logs. To Process the RunMe logs there's a couple things we need to do
Configuration
|
Alternative: Use ULIDs for BlocKIDs
|
* RunMe uses ULIDs for cell ids. If we switch to using ULIDs we can be consistent with what RunMe does and avoid having two different types of ids for blocks. This will avoid a lot of headaches. Related to #110
* RunMe uses ULIDs for cell ids. If we switch to using ULIDs we can be consistent with what RunMe does and avoid having two different types of ids for blocks. This will avoid a lot of headaches. Related to #110
Right now each type of trace is stored in a flat JSONL file foyle/app/pkg/analyze/analyzer.go Line 135 in 23a7b1e
We rely on the filename to know the type of trace. |
With #121 we should be code complete but will need to do some E2E testing to see if its all working. |
* Define a combineRunmeEntries function to generate the RunmeTrace * Define a RunMe trace type * Update Analyzer to parse the RunMe logs and construct traces * Update Analayzer to update the BlockLog based on the RunMe trace * Set the executed command Fix #110
So how do we verify everything is working
Since the RunMe changes haven't been released yet. We need to use our locally built version of RunMe. |
No examples are produced based on the foyle logs. |
I didn't update the learning code to include the directory of the RunMe logs |
* Fix training on RunMe logs #110 * We need to allow Foyle to be configured with the directory of the RunMe logs * Add LearnerConfig to Foyle config with the logs directory * Fix a bug in analyze preventing BlockLogs from being updated with the executed block when using RunMe * The bug was that when looking for the last execution trace; we weren't considering RunMe traces * Update the RunMe developer guide * Update the docs
We need to update our retraining code to work with the data produced by RunMe
The text was updated successfully, but these errors were encountered: