Rag not Enabled by default #249
Comments
jlewi
added a commit
that referenced
this issue
Sep 20, 2024
* Fix #249 * The bug was the function UseRAGEnabled was using a hard coded value for the default rather than the constant. As a result, when we recently changed the default to be true it wasn't actually enabled by default. * Refactor viper processing so its easy to test configuration in a unittest * We want to be able to create instances of viper using viper.New in the unittest so that we don't have to only use the global viper instance. * To support that we refactor InitViper into a separate function which takes as an argument *viper.Viper
This was referenced Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I flipped the value to be true but it doesn't actually get enabled if you have an empty RAG config in your configuration.
The problem is here
foyle/app/pkg/config/config.go
Line 293 in 5f30c46
If the config.Agent is nil or config.Agent.RAG is nil we won't enable RAG but we should. We should return whatever the default value is as set by the constant.
The text was updated successfully, but these errors were encountered: