-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a gRPC service to generate cells for RunMe #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jlewi
commented
May 14, 2024
•
edited
Loading
edited
- Define a GRPC service that will take a RunMe notebook and generate cells to be inserted into that notebook
- The gRPC service is being defined in Define AI GRPC service to support using AI to generate cells stateful/runme#573
- Define converters to and from RunMe protos to Foyle Protos
- Make a copy of RunMe's ULID generator code so we can generate cell ids in the format RunMe expects
- RunMe"s ULID generator code is defined in an internal package so we can't just reuse it.
- Related to tn_004.md runme integration
* We move the runme generate service request into its own buf package because the service definition will need to be shared with the runme codebase.
✅ Deploy Preview for foyle canceled.
|
jlewi
changed the title
Define a service to generate suggestions for RunMe
Implement a gRPC service to generate cells for RunMe
May 15, 2024
Now that runme has merged stateful/runme#573 with the generated protos we can remove the replace directive and we can build this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.