Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a gRPC service to generate cells for RunMe #106

Merged
merged 13 commits into from
May 17, 2024
Merged

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented May 14, 2024

jlewi added 3 commits May 13, 2024 17:28
* We move the runme generate service request into its own buf package because the service definition will need to be shared with the runme codebase.
Copy link

netlify bot commented May 14, 2024

Deploy Preview for foyle canceled.

Name Link
🔨 Latest commit fefc1ab
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/66477cc62c86c200088a3e69

@jlewi jlewi changed the title Define a service to generate suggestions for RunMe Implement a gRPC service to generate cells for RunMe May 15, 2024
@jlewi jlewi marked this pull request as ready for review May 17, 2024 15:50
@jlewi jlewi enabled auto-merge (squash) May 17, 2024 15:51
@jlewi
Copy link
Owner Author

jlewi commented May 17, 2024

Now that runme has merged stateful/runme#573 with the generated protos we can remove the replace directive and we can build this

@jlewi jlewi merged commit fe1bf81 into main May 17, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/runme branch May 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant