Assets download shouldn't use CWD if there is no config file #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When a user runs assets download they may not have created a .foyle/config.yaml file yet * As a result the ConfigDir will be the empty string and assets will be put into the local directory * To solve this if the ConfigFile is empty we return the default config directory.
✅ Deploy Preview for foyle canceled.
|
jlewi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user runs assets download they may not have created a .foyle/config.yaml file yet
As a result the ConfigDir will be the empty string and assets will be put into the local directory
To solve this if the ConfigFile is empty we return the default config directory.
Fix #103