Fix Learning: Cell Executions Not Being Added to BlockLogs #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learning was broken because cell executions were not being properly extracted from LogEvents and added to the BlockLog.
The problem is that the logging of LogEvents happens inside an anonymous function. Therefore the function name generated by GoLang has a suffix like "func1"; therefore our code in the Analyzer was not correctly matching it and therefore log events were not being processed.
The fix is to match by using
HasPrefix
. This is still brittle.Per Fix Brittleness In Logs Processing With Source Detection #232 we'd like to start to fix this brittleness by using reflection and source code analysis in unittests to ensure the correctness of matchers for LogEntries.
This PR introduces a matchers package which verifies correctness of the function name but doesn't properly catch the anonymous function which broke learning here
Update the troubleshooting guide for learning
Strip metadata from markdown