Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Learning: Cell Executions Not Being Added to BlockLogs #233

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Sep 12, 2024

  • Learning was broken because cell executions were not being properly extracted from LogEvents and added to the BlockLog.

  • The problem is that the logging of LogEvents happens inside an anonymous function. Therefore the function name generated by GoLang has a suffix like "func1"; therefore our code in the Analyzer was not correctly matching it and therefore log events were not being processed.

  • The fix is to match by using HasPrefix. This is still brittle.

  • Per Fix Brittleness In Logs Processing With Source Detection #232 we'd like to start to fix this brittleness by using reflection and source code analysis in unittests to ensure the correctness of matchers for LogEntries.

  • This PR introduces a matchers package which verifies correctness of the function name but doesn't properly catch the anonymous function which broke learning here

  • Update the troubleshooting guide for learning

    • Move the troubleshooting guide into the docs page
    • Update the instructions for fetching the blocklogs; we now use the connect protocol

Strip metadata from markdown

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for foyle ready!

Name Link
🔨 Latest commit cf00528
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/66e34bf45e47c1000908ef70
😎 Deploy Preview https://deploy-preview-233--foyle.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlewi jlewi merged commit c806b60 into main Sep 12, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/debuglearn branch September 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant