Stop forcing cells to be non-interactive #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Forcing cells to be non-interactive was a temporary fix for the fact that the output wasn't included in Foyle completion requests (#286) * This is now fixed in the frontend so that the output of interactive cells is included in the requests to Foyle * We don't want to default to non-interactive cells because non-interactive cells don't show stderr Related to /issues/286
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
✅ Deploy Preview for foyle canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing cells to be non-interactive was a temporary fix for the fact that the output wasn't included in Foyle completion requests (Cell Outputs aren't actually included in the LLM request. #286)
This is now fixed in the frontend so that the output of interactive cells is included in the requests to Foyle
We don't want to default to non-interactive cells because non-interactive cells don't show stderr
Related to /issues/286