Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start setting blockID to support logging human feedback #46

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Apr 11, 2024

  • Add the BlockID to the proto
  • Instrument the Agent.Generate RPC to lock the blockIDs of any generated blocks
  • Instrument the Executor.Execute RPC to log the IDS of any blocks executed
  • Configure OTEL so that trace and spans get set. We will use this to link the log entries
    associated with a trace.
  • Add the ability to send traces to Honeycomb

Related to #7

* Add the BlockID to the proto
* Instrument the Agent.Generate RPC to lock the blockIDs of any generated blocks
* Instrument the Executor.Execute RPC to log the IDS of any blocks executed
* Configure OTEL so that trace and spans get set. We will use this to link the log entries
  associated with a trace.
* Add the ability to send traces to Honeycomb
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for foyle ready!

Name Link
🔨 Latest commit 2b8ce1e
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/6617447667c1cf0008fe2d0c
😎 Deploy Preview https://deploy-preview-46--foyle.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlewi
Copy link
Owner Author

jlewi commented Apr 11, 2024

Since the proto change creates an incompatibility between the frontend and backend we shouldn't release this until we've fixed the issues with pinning assets.

@jlewi
Copy link
Owner Author

jlewi commented Apr 13, 2024

The 0.0.4 is now pinning the commit of the image.

2024-04-12T17:22:43.441-0700	INFO	cmd/version.go:41	binary version	{"version": "0.0.4", "commit": "51a604f692eb0803c7d2dcc00fac7709df1fa822", "date": "2024-04-13T00:11:00Z", "builtBy": "goreleaser"}
2024-04-12T17:22:43.441-0700	INFO	cmd/assets.go:63	Downloading assets	{"tag": "51a604f692eb0803c7d2dcc00fac7709df1fa822"}
2024-04-12T17:22:43.441-0700	INFO	assets/manager.go:81	Downloading assets	{"downloadDir": "/var/folders/pc/wqw4h6c54_x2s33qgmdzf9_w0000gn/T/temporaryAssets947028670"}
2024-04-12T17:22:43.441-0700	INFO	assets/manager.go:116	Asset already exists	{"assetDir": "/Users/jlewi/.foyle/assets/vscode", "name": "vscode", "source": "ghcr.io/jlewi/vscode-web-assets"}
2024-04-12T17:22:43.441-0700	INFO	assets/manager.go:126	Downloading asset	{"name": "foyle", "source": "ghcr.io/jlewi/foyle-vscode-ext", "tarBall": "/var/folders/pc/wqw4h6c54_x2s33qgmdzf9_w0000gn/T/temporaryAssets947028670/foyle.tar.gz"}
2024-04-12T17:22:45.138-0700	INFO	assets/manager.go:149	Unpacking tarball	{"srcTarball": "/var/folders/pc/wqw4h6c54_x2s33qgmdzf9_w0000gn/T/temporaryAssets947028670/foyle.tar.gz", "dest": "/Users/jlewi/.foyle/assets/foyle", "stripPrefix": "foyle"}
2024-04-12T17:22:45.147-0700	INFO	application/app.go:103	Shutting down the application

So this is safe to merge.

@jlewi jlewi merged commit c6d2e14 into main Apr 13, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/logging branch April 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant