Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown documents #65

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Support markdown documents #65

merged 9 commits into from
Apr 19, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Apr 19, 2024

  • Use VSCode's markdown notebook extension as the basis for markdown support
  • To support markdown we define a new new notebook type foyle-notebook-md and then register another copy of the controller for it
  • The reason we need to register a new notebook-type is because serializers appear to be linked to the notebook-type. Within the serializer it didn't seem like we could easily get the original filename extension to determine what the encoding was.

Fix #19

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for foyle canceled.

Name Link
🔨 Latest commit 960d314
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/6622d61294cd6f000899b735

@jlewi jlewi merged commit 09fe389 into main Apr 19, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/markdown branch April 19, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support markdown documents
1 participant