Evaluation Results Data Explorer #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerate the handler.
… a problem before but with the connect protocl it is a problem.
…g bug.
You can send a curl request as
curl \
--header "Content-Type: application/json" \
--data '{"name": "Jane"}' \
http://localhost:8080/EvalService/List
✅ Deploy Preview for foyle canceled.
|
… on items. So next step is to try to actually get the data and load it.
Load the data from the backend using the connect client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Google Sheet To View the evaluation results isn't working too well. So we create our own viewer to display the results.
Create a connect-rpc service for listing the evaluation results
This is the first step to building a viewer for the evaluation results; we need a service to allow the client app to read the results.
We decided to go with connect-rpc because this should simplify things by eliminating the need to use grpc and gprc gateway in order to have a service that we can connect to from the browser
Furthermore, hopefully we can use the connect-rpc generated clients even when using WASM
Fix the go_package option in most of the proto files. We seem to be missing a directory "foyle" in the path. This doesn't appear to matter until we start using connect-rpc and then the imports are broken unless we fix the package
Refactor our existing go-app to better support multiple pages. Each page might render the right hand side differently.
The app is pretty ugly. I will try to fix the styling in a subsequent PR.