Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger in repo controller doesn't set name correctly #67

Closed
jlewi opened this issue Jan 30, 2024 · 1 comment · Fixed by #68
Closed

Logger in repo controller doesn't set name correctly #67

jlewi opened this issue Jan 30, 2024 · 1 comment · Fixed by #68

Comments

@jlewi
Copy link
Owner

jlewi commented Jan 30, 2024

Our logger is intended to set the name of the resource in all log entries so we can easily find the log entries for a specific resource.
Here are the log entries for logbook
logs

We're seeing log messages that pertain to other resources

This is commit:
7a6a0fe

@jlewi
Copy link
Owner Author

jlewi commented Jan 30, 2024

The bug is here

log.Error(err, "Error applying resource", "path", r.path, "name", r.node.GetName())

The log is referencing the unbound loop variables which is why its the same.

jlewi added a commit that referenced this issue Jan 30, 2024
@jlewi jlewi closed this as completed in #68 Jan 30, 2024
jlewi added a commit that referenced this issue Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant