Remove dependency on skaffold #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Depending on skaffold causes versioning issues. * Current issue is that skaffold depends on old versions of otel (open telemetry clients) and vendors those in. The open telemetry clients aren't backwards compatible (skaffold is using a version prior to their v1 release) * skaffold isn't really a library so arguably they aren't breaking us * Currently skaffold is invoked via exec'ing out to it so arguably there's no reason to pay the pain of pulling it in as a dependency * The only code we are pulling in from the skaffold package is the structures for skaffold configs and build output we can just copy those files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those in. The open telemetry clients aren't backwards compatible (skaffold is using a version prior to their v1 release)
we can just copy those files.