Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image should support pulling artifacts from docker images to build the context #64

Merged
merged 18 commits into from
Jan 30, 2024
Merged

Image should support pulling artifacts from docker images to build the context #64

merged 18 commits into from
Jan 30, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Jan 28, 2024 •
edited
Loading

  • Redo Image API
    • Refer to docs/image_build.md
    • Image should support pulling artifacts from docker images to build the context
  • The "base" for sourceMappings should be specified as a URI
    • URI could be a docker image or a git repo
    • src locations are relative to that resource
  • The hydros CLI will take care of replacing the location of the git repo with the local cloned copy if there is one.
  • Allow the location of the Dockerfile in the context to be specified

@jlewi jlewi marked this pull request as ready for review January 30, 2024 14:56
@jlewi jlewi merged commit 7a6a0fe into main Jan 30, 2024
1 check passed
@jlewi jlewi deleted the jlewi/syncer branch January 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jlewi