Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubReleaser resource #92

Merged
merged 4 commits into from
Apr 12, 2024
Merged

GitHubReleaser resource #92

merged 4 commits into from
Apr 12, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Apr 12, 2024

  1. New GitHub Releaser Resource: A new GitHubReleaser resource has been defined in api/v1alpha1/releaser.go, indicating functionality for automated GitHub releases based on specific conditions such as new commits to a repository.

  2. Releaser Implementation: A new package pkg/github/releaser.go implements the logic for the GitHub Releaser functionality, including creating new GitHub releases and generating release notes automatically.

  3. Create a RepoConfig and GitHubReleaser object to release hydros

  4. GitHub App Configuration Removal: Changes in api/v1alpha1/repo.go remove the GitHubAppConfig from the RepoSpec, simplifying the configuration by focusing on repository URLs and glob patterns for file matching instead.

    • Now that we use Cobra the GitHubApp configuration should be provided in the hydros configuration not in the resource
  5. Improved Test Configuration: Modifications to the Makefile introduce the use of a GITHUB_ACTIONS environment variable during tests to presumably alter behavior when tests are run in GitHub Actions CI/CD environments.

  6. Expanded Project Description: The README.md file has been significantly updated to provide a more detailed introduction to Hydros, outlining its declarative approach to continuous delivery, and providing examples of how to use the tool. It also highlights the shift from the project being specifically tailored to Primer's workflow to a more generalized tool that could be beneficial to a broader audience.

  7. Detailed Documentation Updates: Several documentation files, including continuous_delivery.md and setup.md, have been updated or added to provide in-depth guidance on setting up and using Hydros for continuous delivery, emphasizing its declarative nature and flexibility.

  8. GitHub Releaser Test: A test case for the Releaser logic has been added to pkg/github/releaser_test.go, ensuring the functionality behaves as expected under specific conditions.

  9. Refined Repo Controller: The RepoController logic within pkg/gitops/repocontroller.go and its test in repocontroller_test.go have been adjusted to accommodate the changes introduced, particularly the removal of GitHub app-specific configuration in favor of a more generalized approach.

@jlewi jlewi enabled auto-merge (squash) April 12, 2024 22:34
@jlewi jlewi merged commit 61c688b into main Apr 12, 2024
1 check passed
@jlewi jlewi deleted the jlewi/ghreleaser branch April 12, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant