Skip to content

Commit

Permalink
Fix copy-artifacts step in mnist notebook tests.
Browse files Browse the repository at this point in the history
* Python path should be /srcCache not /src

* Related to GoogleCloudPlatform/kubeflow-distribution#65
  • Loading branch information
Jeremy Lewi committed Jun 30, 2020
1 parent 28a6150 commit bca2fa3
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ spec:
- python
env:
- name: PYTHONPATH
value: /src/kubeflow/testing/py
value: /srcCache/kubeflow/testing/py
image: $(inputs.params.test-image)
name: copy-artifacts
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ spec:
- python
env:
- name: PYTHONPATH
value: /src/kubeflow/testing/py
value: /srcCache/kubeflow/testing/py
image: $(inputs.params.test-image)
name: copy-artifacts
13 changes: 13 additions & 0 deletions docs/tekton.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,19 @@ To update the hydrated manifests
make hydrate
```

## Debugging

### TaskRun Logs

If the logs aren't available in the Tekton UI you can fetch them with a query like the one below.

```
resource.type="k8s_container"
resource.labels.cluster_name="kf-ci-v1"
labels."k8s-pod/tekton_dev/taskRun" = "mnist-wc6fq-run-notebook-d9q7w"
resource.labels.container_name = "step-copy-artifacts"
```

## Running on your own Tekton cluster

You should be able to run the KF Tekton pipelines on your own Tekton cluster provided you install
Expand Down
2 changes: 1 addition & 1 deletion tekton/templates/tasks/notebook-test-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ spec:
- --output_gcs=$(inputs.params.artifacts-gcs)
env:
- name: PYTHONPATH
value: /src/kubeflow/testing/py
value: /srcCache/kubeflow/testing/py
---
# This task builds a docker image to run notebooks in.
# It takes as a base image a notebook image and adds
Expand Down

0 comments on commit bca2fa3

Please sign in to comment.