Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for codebuild github PR refs pattern #45

Merged
merged 1 commit into from
May 11, 2024

Conversation

mufaddal-rohawala
Copy link

@mufaddal-rohawala mufaddal-rohawala commented Apr 11, 2024

Im from SageMaker Python SDK Team, we had to recently switch the codeebuild PR triggers to
SourceVersion = refs/pull/{pr-number}/head^{full-commit-SHA}) pattern.

To continue to support PR Comments via this fantastic tool, I wish to add support for this pattern.

More Info in: https://docs.aws.amazon.com/codebuild/latest/userguide/sample-source-version.html

Let me know if more details are needed.

@jlhood
Copy link
Owner

jlhood commented May 11, 2024

Apologies for the delay on this. The change looks like it's not going to break existing usage. I haven't personally tested the new regex pattern though. Did you? I'm happy to merge this. I'll verify it doesn't break existing functionality, but I'll need your help verifying the new support for refs. Will ping you offline re: testing.

Note, I checked the CodeBuild failure and it's unrelated to your change so I'm going ahead and merging even with the CodeBuild failure. I'll fix that separately.

@jlhood jlhood merged commit 7fe17d8 into jlhood:master May 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants