Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShellFactoryImpl.ShellImpl ignores the session #382

Closed
tpoliaw opened this issue Apr 18, 2019 · 0 comments · Fixed by #385
Closed

ShellFactoryImpl.ShellImpl ignores the session #382

tpoliaw opened this issue Apr 18, 2019 · 0 comments · Fixed by #385

Comments

@tpoliaw
Copy link
Contributor

tpoliaw commented Apr 18, 2019

I have an embedded SSH server and am using ShellFactoryImpl(Consumer<ShellParams>) to create the ShellFactory.

ShellImpl implements SessionAware and has the session set, but there's no way for the shell function to use it as the ShellParams do not include it. I would like to access details from the Session in the shell (mainly for the client address).

Could ShellParams (and ExecuteParams) include the session? If this is ok, I'll work on a PR for it.
ghost pushed a commit to tpoliaw/jline3 that referenced this issue Apr 24, 2019
@tpoliaw
Make ShellParams and ExecuteParams aware of the session
e563cca 
This allows shell implementations to have access to the session.
Fixes jline#382
ghost pushed a commit to tpoliaw/jline3 that referenced this issue Apr 24, 2019
@tpoliaw
Make ShellParams and ExecuteParams aware of the session
860c0d6 
This allows shell implementations to have access to the session.
Fixes jline#382
@tpoliaw tpoliaw mentioned this issue Apr 24, 2019
Merged
snuyanzin pushed a commit to snuyanzin/jline3 that referenced this issue May 6, 2019
@tpoliaw @snuyanzin
Make ShellParams and ExecuteParams aware of the session
b847ae8 
This allows shell implementations to have access to the session.
Fixes jline#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ShellParams and ExecuteParams aware of the session tpoliaw/jline3
1 participant
@tpoliaw