CollectionIncompatibleType bug in TerminalBuilder found by Error Prone

[vorburger]

I'm running https://errorprone.info on this project, and it claims to have found a bug (line numbers are as of 3.23.0):

terminal/src/main/java/org/jline/terminal/TerminalBuilder.java:407: error: [CollectionIncompatibleType] Argument 'l' should not be passed to this method; its type TerminalProvider is not compatible with its collection's type argument String
            int idx = order.indexOf(l);

See https://errorprone.info/bugpattern/CollectionIncompatibleType ... @gnodet from a quick glance, I think this is a real bug, not a false positive, this does seem wrong (because it mixes TerminalProvider and String):

List<TerminalProvider> providers;
List<String> order;

providers.sort(Comparator.comparing(l -> {
            int idx = order.indexOf(l);
            return idx >= 0 ? idx : Integer.MAX_VALUE;
        }));

@cushon just FYI

[vorburger]

FYI I've not actually really directly run ErrorProne on JLine, but I'm building JLine in an internal build system at work where this pops up. I have created #847 re. actually adding ErrorProne to jline3 (as in, to the pom.xml of this project / Git repo), so this issue can be about the specific issue above, only.

[jvalkeal]

Yes, that is a bug. Even eclipse/vscode gives warning for it

Unlikely argument type TerminalProvider for indexOf(Object) on a List

Should be

providers.sort(Comparator.comparing(l -> {
	int idx = order.indexOf(l.name());
	return idx >= 0 ? idx : Integer.MAX_VALUE;
}));

and sorting starts to work.

[gnodet]

Nice, can one of you create a PR for that ?

[jvalkeal]

Yes, I can push a PR

[jvalkeal]

@gnodet Did a pr #852 for this.