Prevent index errors moving through completion menu #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduces slight change in behaviour: Left/right and up/down will now only change column and row respectively. ie. Moving left from the first column moves to the last column on the _same_ row, not the one above.
ghost
|
Not sure why the appveyor tests timed out. I'm happy to make any changes but I can't see what's causing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #192. There is still an issue in cases where the number of columns is calculated incorrectly (see #191).
Also introduces slight change in behaviour:
Left/right and up/down will now only change column and row
respectively.
ie. Moving left from the first column moves to the last column
on the same row, not the one above.