Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build changes for GCC-9, MacOS Catalina and new netcdf binary and library installed with Homebrew #16

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Conversation

bokjo
Copy link
Contributor

@bokjo bokjo commented Dec 1, 2019

Hello @jllodra,

Thanks for ncdump-json, really appreciated it!

I had to install it on macOS Catalina and had some problems so here are some improvements that fixed it for me.

Sorry I didn't have enough time to parameterize everything and some Linux or Windows to test it too.
I believe that the Linux package is really similar and for Windows using something like Chocolatey to install the latest version of netcdf should do the job.

NOTE: for the dynamic libs in cmake for Linux you should use '*.so' and for Windows '*.dll' files

Flow...

Since the brew package homebrew/science/netcdf is no longer available you have to install the new package with comes with the libraries and the included header files.

brew install netcdf

The netcdf package also installs the latest GCC (v9) which should be enough
Brew standard install location is /usr/local/Cellar

Also, you need the pkg-config installed which is not listed in the installation steps.

Putting this here so someone checking it can use it...

1. $ brew install netcdf
2. $ brew install pkg-config
3. $ brew install cmake

@jllodra
Copy link
Owner

jllodra commented Dec 5, 2019

Hi @bokjo,

Thank you so much for your contribution. MacOS users will appreciate this!

I haven't looked at your changes yet, but you say you haven't tested on Linux. Do you have the time to do a quick test on latest Debian or Ubuntu and share your findings before merging?

Warm regards

@bokjo
Copy link
Contributor Author

bokjo commented Dec 5, 2019

Hi @bokjo,

Thank you so much for your contribution. MacOS users will appreciate this!

I haven't looked at your changes yet, but you say you haven't tested on Linux. Do you have the time to do a quick test on the latest Debian or Ubuntu and share your findings before merging?

Warm regards

Hello @jllodra,

I'll try to check it out on Linux this weekend and add different parameterized build variables for MacOS(APLLE) and Linux ( unfortunately cannot check for Windows)

For macOS, I'm assuming that the user will install NetCDF with Homebrew.
Hope that different package manages for Linux distros behave similarly and that the latest version of NetCDF comes with the libraries as well.

Will let you know the outcome.

Kind Regards,
Bojanche S.

@bokjo
Copy link
Contributor Author

bokjo commented Dec 8, 2019

Hello @jllodra

I've checked on Ubuntu 18.04 LTS with GCC7 and Debian10 with GCC8 and managed to build it with one simple hack! (I don't know why the .so files are missing but the hack did the job)

cd /usr/lib/x86_64-linux-gnu

sudo ln -s libhdf5_serial.so libhdf5.so

sudo ln -s libhdf5_serial_hl.so libhdf5_hl.so

The idea is from this Github issue here

I've also added the parameterized check for building on macOS and the missing pkg-config in the README

Kind Regards,
@bokjo

@jllodra jllodra merged commit 64aaacf into jllodra:master Dec 9, 2019
@jllodra
Copy link
Owner

jllodra commented Dec 9, 2019

Thank you for this!

@bokjo
Copy link
Contributor Author

bokjo commented Dec 10, 2019

Thank you for this!

My pleasure :)

@BobHu14
Copy link

BobHu14 commented Jul 29, 2020

Can you provide the converted JSON file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants