eve/alert: fix validation check

Bug: OISF#6875. (cherry picked from commit 0be3ba8)
jlucovsky · Aug 18, 2024 · 6c03f8b · 6c03f8b
1 parent 0764d7a
commit 6c03f8b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/output-json-alert.c b/src/output-json-alert.c
@@ -873,8 +873,8 @@ static int AlertJson(ThreadVars *tv, JsonAlertLogThread *aft, const Packet *p)
             int stream = (p->proto == IPPROTO_TCP) ?
                          (pa->flags & (PACKET_ALERT_FLAG_STATE_MATCH | PACKET_ALERT_FLAG_STREAM_MATCH) ?
                          1 : 0) : 0;
-            DEBUG_VALIDATE_BUG_ON(
-                    p->flow == NULL); // should be impossible, but scan-build got confused
+            // should be impossible, as stream implies flow
+            DEBUG_VALIDATE_BUG_ON(stream && p->flow == NULL);
 
             /* Is this a stream?  If so, pack part of it into the payload field */
             if (stream && p->flow != NULL) {