Skip to content

Commit

Permalink
Refs #50 updated the pull request template
Browse files Browse the repository at this point in the history
  • Loading branch information
jmborr committed Apr 20, 2018
1 parent cf17385 commit 06cac47
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,21 @@ Description of work.

Fixes #xxxx. <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->

**Release Notes**
<!--
Either edit the file in docs/source/release/... and it will be in your pull request or state
*Does not need to be in the release notes.*
-->

---

##### Code Review #####

- [ ] Is the code of an acceptable quality?
- [ ] Does the code conform to the [coding standards]?
- [ ] Are the unit tests small and test the class in isolation?
- [ ] If there are changes in the release notes then do they describe the changes appropriately?
- [ ] If there are changes in HISTORY.rst then do they describe the changes appropriately?

##### Functional Tests #####

- [ ] Do changes function as described? Add comments below that describe the tests performed?
- [ ] Do the changes handle unexpected situations, e.g. bad input?

##### Documentation #####

- [ ] Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as **Approve**. A member of `@idpflex/gatekeepers` will take care of it.
Does everything look good? Mark the review as **Approve**. A member of `@qef/gatekeepers` will take care of it.

0 comments on commit 06cac47

Please sign in to comment.