Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean power Update #150

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Mean power Update #150

merged 2 commits into from
Nov 3, 2023

Conversation

adi90x
Copy link
Contributor

@adi90x adi90x commented Nov 1, 2023

Hello,
Reference Issue #146
Mean Power shouldn't multiply device_power by number of heater registered.
Also add a small information on that in the documentation.

@adi90x adi90x mentioned this pull request Nov 1, 2023
@jmcollin78
Copy link
Owner

Hello @adi90x ,

Thank you for your PR. I wonder why no unit tests have changed. It seems not normal if the rule changed.

@adi90x
Copy link
Contributor Author

adi90x commented Nov 3, 2023

@jmcollin78 I guess there is no unit test for that 😁

@jmcollin78
Copy link
Owner

jmcollin78 commented Nov 3, 2023

@jmcollin78 I guess there is no unit test for that 😁

Does test_power.py pass ?
If you change something, something must break or please add a test that shows what you have done works.

EDIT : I try with your change and all pass without error. So can you please add a test that shows you change works ? In long terms, it is essential to have a good coverage of the code. Thank you in advance. You have the test_power.py in example if you want.

@adi90x
Copy link
Contributor Author

adi90x commented Nov 3, 2023

@jmcollin78 I guess there is no unit test for that 😁

Does test_power.py pass ? If you change something, something must break or please add a test that shows what you have done works.

EDIT : I try with your change and all pass without error. So can you please add a test that shows you change works ? In long terms, it is essential to have a good coverage of the code. Thank you in advance. You have the test_power.py in example if you want.

I think that it pass because test is done with only one heater so there is no difference in the mean_cycle_power to I update. Will try to switch test_power_management_energy_over_switch to use 2 heater.

@adi90x
Copy link
Contributor Author

adi90x commented Nov 3, 2023

Hello,
Was quick in fact previous test was using mean_power_cycle attribute instead of device_power.
Test is OK with the commit and NOK before.

@jmcollin78 jmcollin78 merged commit 9abcd98 into jmcollin78:main Nov 3, 2023
4 checks passed
@jmcollin78
Copy link
Owner

Thank you @adi90x !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants