fix for 'It's not possible to set regulation mode to Expert using Automations' #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcollin78
reviewed
Dec 19, 2024
|
Hi @jmcollin78,
It’s tested and working after HA restart.
Only needed to change the code in climate.py
…________________________________
Van: Jean-Marc Collin ***@***.***>
Verzonden: Thursday, December 19, 2024 5:52:45 PM
Aan: jmcollin78/versatile_thermostat ***@***.***>
CC: Edwin ten Haaf ***@***.***>; Author ***@***.***>
Onderwerp: Re: [jmcollin78/versatile_thermostat] fix for 'It's not possible to set regulation mode to Expert using Automations' (PR #718)
@jmcollin78 commented on this pull request.
Hello, thank you for this. Is this working as is ? Is there any backend update needed ?
—
Reply to this email directly, view it on GitHub<#718 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMISZYWQDFHTNNKPCCWPM7T2GL2V3AVCNFSM6AAAAABT4KUCECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJVGU3DKMJXGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Merged ! Thank you @Edwintenhaaf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #717
'Failed to perform the action versatile_thermostat.set_auto_regulation_mode. value must be one of ['Light', 'Medium', 'None', 'Slow', 'Strong'] for dictionary value @ data['auto_regulation_mode']. Got None'