Test functionality of automatic conversion in ccall #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for the `cconvert` method used implicitly during `ccall`s. When designing the tests, though, it became obvious that real-world conversion to `Cint` arguments (such as calls to `mmap` in UnixMmap.jl) weren't covered by the existing method. Change the behavior to allow for conversion to any integer type which can be represented by the destination type.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
===========================================
+ Coverage 99.34% 100.00% +0.65%
===========================================
Files 1 1
Lines 153 153
===========================================
+ Hits 152 153 +1
+ Misses 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the
cconvertmethod used implicitly duringccalls. When designing the tests, though, it became obvious that real-world conversion toCintarguments (such as calls tommapin UnixMmap.jl) weren't covered by the existing method.Change the behavior to allow for conversion to any integer type which can be represented by the destination type.