Adding Unit test for File size!!! #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling to latest changes
If the parrot has only HD name the slack names will be translated to HD-bla bla bla. So to avoid this I added a replace to delete the heading "HD-"
|
The travis is saying that convet-units is missing but I'm adding it in the package.json with my commit. |
Merged
|
+1 for separation! We can probably drop the convert-units and replace with a constant TBH, I'll poke at travis though. |
|
I don't run a full npm install in travis because we don't need all the packages. Can you update |
|
Initially I was with the constant approach but I though that it will be more elegant using a module instead of a constant. |
|
Nah, looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parrots need to be checked since slack requires parrots with 64kb or less