Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'others' section and zip. #169

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Add 'others' section and zip. #169

merged 2 commits into from
Nov 7, 2017

Conversation

jmhobbs
Copy link
Owner

@jmhobbs jmhobbs commented Nov 7, 2017

For #167, and solving #168.

Not sure I like the headline "Other Party Things" but I couldn't come up with a better one.

screen shot 2017-11-06 at 9 44 26 pm

cc @danrichman @cavpolloosigu

@jmhobbs
Copy link
Owner Author

jmhobbs commented Nov 7, 2017

Lots of code duplication, especially in tests, but I wasn't motivated enough to clean it up. ¯\_(シ)_/¯

@danrichman
Copy link
Contributor

@jmhobbs Other Party Things seems fine to me. But, If you're unsatisfied with that, could also do something like: Other Party Guests

@jmhobbs
Copy link
Owner Author

jmhobbs commented Nov 7, 2017

Oh man, I really like the guests idea. I'll change that up.

@jmhobbs jmhobbs merged commit ca836f2 into master Nov 7, 2017
@jmhobbs jmhobbs deleted the party-friends branch November 7, 2017 05:52
This was referenced Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants