-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default locale path discovering. #146
Conversation
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
===========================================
+ Coverage 99.42% 100.00% +0.57%
===========================================
Files 9 9
Lines 524 554 +30
===========================================
+ Hits 521 554 +33
+ Misses 3 0 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Just a few minor suggestions :)
All resolved, seems that coverage upload is failing... |
Thanks! Yeah, the coverage upload has been a bit flaky of late, nothing to worry about here. I've restarted the CI (but it might fail again 🙃). |
Thank you! |
Changes proposed in this pull request:
humanize.i18n.activate
function is called.__file__ is None
and__file__
not defined cases.