Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sqlserver parameters syntax #406

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

marpio
Copy link
Contributor

@marpio marpio commented Apr 15, 2018

Fixes: #374 , #291

@coveralls
Copy link

coveralls commented Apr 15, 2018

Pull Request Test Coverage Report for Build 18

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 71.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bind.go 2 4 50.0%
Totals Coverage Status
Change from base Build 17: 0.05%
Covered Lines: 1086
Relevant Lines: 1511

💛 - Coveralls

@stanislas-m
Copy link

Hello @jmoiron, we need this to add support for MS SQL server in https://github.com/gobuffalo/pop

Let me know if you need some help. :)

@HarveyKandola
Copy link

Any reason why this has not been merged yet?

@genez
Copy link

genez commented Sep 28, 2018

Hello, I would like to make use of this fix in order to correctly bind "IN" clause with mssql driver

@stanislas-m
Copy link

Thanks a lot @jmoiron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants