Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bulk Insert: Allow single column and allow VALUES after ON DUPLICATE KEY #732

Closed
wants to merge 2 commits into from
Closed

Fix Bulk Insert: Allow single column and allow VALUES after ON DUPLICATE KEY #732

wants to merge 2 commits into from

Conversation

QuangTung97
Copy link
Contributor

@QuangTung97 QuangTung97 commented Apr 27, 2021 •
edited
Loading

This change handle the case of using single column in "VALUES(...)".
And allow using VALUES in "INSERT ... ON DUPLICATE KEY UPDATE ..." kind of queries, issue #722

@coveralls
Copy link

coveralls commented Apr 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 236

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 74.166%
Totals Coverage Status
Change from base Build 224: 0.3%
Covered Lines: 1223
Relevant Lines: 1649
💛 - Coveralls

@QuangTung97 QuangTung97 force-pushed the master branch 2 times, most recently from 65b5043 to 1747e4b Compare April 27, 2021 08:35
@QuangTung97 QuangTung97 changed the title Fix to allow single column and allow VALUES after ON DUPLICATE KEY Fix Bulk Insert: Allow single column and allow VALUES after ON DUPLICATE KEY Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuangTung97 @coveralls