Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spamming logs with unnecessary log entries for metadata mismatch #542

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Avoid spamming logs with unnecessary log entries for metadata mismatch #542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions logging/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package logging

import (
"github.com/jmpsec/osctrl/backend"
"github.com/rs/zerolog/log"
)

const (
Expand Down Expand Up @@ -33,7 +32,6 @@ func sameConfigDB(loggerOne, loggerTwo backend.JSONConfigurationDB) bool {
// Helper to be used preparing metadata for each decorator
func metadataVerification(dst, src string) string {
if src != dst {
log.Warn().Msgf("mismatched metadata: %s != %s", dst, src)
if dst == "" {
return src
}
Expand Down
Loading