-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude is not working #348
Comments
I just had the same problem and figured it out.
|
Interesting. I'll give that a try. Thanks! |
Yep, a lot of options require to be an array. We should probably also allow a single entry and convert it to an array when needed. |
I'm running grunt-browserify v4.0.1, grunt v0.4.5 and browserify v12.0.1 and have this problem too... I have a directory with all my source, which I browserify like this:
and everything is fine, except that when I drop an
here's what I currently have:
but like others, I've tried
all which fail in the same manner. curiously, the last attempt generates a different error:
what am I doing wrong? |
I can confirm, that this issue also occurs with ignore. Also tired several ways, like @ekkis , nothing helped. |
My fix above was wrong, it is a side effect.
This may also work with exclude? |
I know there have been other issues to this effect that have been resolved, so it's possible I'm doing this wrong. I want to set up two different bundles, one that includes lodash and one that is a standalone for people who have lodash included in their client scripts already. It looks like the right option is
exclude
(although I've also triedignore
), but I can't get grunt-browserify to leave out lodash. Here's my configuration for the two different bundles:As I mentioned, I've also tried replacing
exclude
withignore
and I've tried putting both inside browserifyOptions, and in all cases, lodash is still included in the build. Incidentally, when I do this directly with browserify, it works fine:browserify dist/request-decoration.js --exclude lodash --standalone FtoggleRequestDecoration > dist/feature-toggle-lib-standalone.js
.I know you'll ask what version I'm using; I updated to the most recent (^4.0.0) when this wasn't working, and that did not fix it.
The text was updated successfully, but these errors were encountered: