Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ACTIVATE_VERSION experimental Singer column #124

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jmriego
Copy link
Owner

@jmriego jmriego commented Jun 28, 2022

Problem

Add support for the experimental Singer command ACTIVATE_VERSION that removes records from non-matching versions. Needed to support tables with hard deletes where log based replication isn't available. This command isn't documented anywhere that I can find, but it seems like a few taps and targets support it, best reference I've found is https://gitlab.com/meltano/meltano/-/issues/2508

Proposed changes

Using _sdc_table_version, which is defined in the Stitch docs here: https://www.stitchdata.com/docs/replication/loading/system-tables-columns

Types of changes

What types of changes does your code introduce to target-bigquery?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@jmriego jmriego temporarily deployed to Integrate Pull Request June 28, 2022 10:32 Inactive
@jmriego jmriego temporarily deployed to Integrate Pull Request June 28, 2022 10:32 Inactive
@jmriego jmriego temporarily deployed to Integrate Pull Request June 28, 2022 10:32 Inactive
@jmriego jmriego mentioned this pull request Jun 28, 2022
13 tasks
@jmriego jmriego changed the title create configuration for tracking hard deletes with scd version support ACTIVATE_VERSION experimental Singer column Jun 28, 2022
@jmriego jmriego merged commit 9738d2c into master Jun 28, 2022
@jmriego jmriego deleted the activate_version branch June 28, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant