Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues.
The Edwards RFC9380 testcases were not actually testing the things they were meant to be testing. This forced some changes in the way structure of the
map_to_point
functions as mapping to Montgomery, then to Edwards was missing a sign bit.The high order two bits of the representative are always 0 by default because correctly computed elligator2 representatives always finish with a
sqrt()
that takes the least-square-root value. That is, a value less than2^254-10
(254 bits).map_to_point_unbounded()
function is added that does not clear the high order bits before mapping to the curve.