Code readability

.rubocop.yml

@@ -22,6 +22,7 @@ Style/PercentLiteralDelimiters:
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'
+    - '*.gemspec'
 Security/MarshalLoad:
   Exclude:
     - 'lib/candy_check/play_store/discovery_repository.rb'

Guardfile

@@ -2,8 +2,10 @@
 # More info at https://github.com/guard/guard#readme
 
 ## Uncomment and set this to only include directories you want to watch
-directories %w(lib spec) \
-  .select { |d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist") }
+directories(
+  %w(lib spec) \
+    .select { |d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist") },
+)
 
 ## Note: if you are using the `directories` clause above and you are not
 ## watching the project directory ('.'), then you will want to move

lib/candy_check/play_store/subscription_purchases/subscription_purchase.rb

@@ -5,7 +5,8 @@ module SubscriptionPurchases
       class SubscriptionPurchase
         include Utils::AttributeReader
 
-        # @return [Google::Apis::AndroidpublisherV3::SubscriptionPurchase] the raw subscription purchase from google-api-client
+        # @return [Google::Apis::AndroidpublisherV3::SubscriptionPurchase] the raw subscription purchase
+        #   from google-api-client
         attr_reader :subscription_purchase
 
         # The payment of the subscription is pending (paymentState)

spec/play_store/acknowledger_spec.rb

@@ -21,7 +21,9 @@
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)
@@ -33,7 +35,9 @@
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)

spec/play_store/product_acknowledgements/acknowledgement_spec.rb

@@ -27,7 +27,9 @@
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.call!
@@ -39,7 +41,9 @@
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.call!

spec/spec_helper.rb

@@ -37,13 +37,13 @@ def in_continuous_integration_environment?
 
 ENV["DEBUG"] && Google::APIClient.logger.level = Logger::DEBUG
 
-class MiniTest::Spec
-  class << self
-    alias context describe
+module MiniTest
+  class Spec
+    class << self
+      alias context describe
+    end
   end
-end
 
-module MiniTest
   module Assertions
     # The first parameter must be ```true```, not coercible to true.
     def assert_true(obj, msg = nil)