Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tool improvements #108

Open
HelenwoodsJNCC opened this issue Nov 11, 2020 · 5 comments
Open

Filter tool improvements #108

HelenwoodsJNCC opened this issue Nov 11, 2020 · 5 comments

Comments

@HelenwoodsJNCC
Copy link

HelenwoodsJNCC commented Nov 11, 2020

Hi @andyb-esdm @SimonAnnetts,

I'm wondering if it's possible to make a few hopefully simple improvements to the filtering functionality to improve the user experience:

  1. When you click on the filter button the pop-up window closes so the user knows something has happened
  2. Where there are multiple filter options on a layer is it possible to order the filters? Currently the order of them seems to change - it would be useful if we could control which order they appeared in.
@HelenwoodsJNCC
Copy link
Author

@andyb-esdm @SimonAnnetts - any thoughts on this?

@andyb-esdm
Copy link
Collaborator

@HelenwoodsJNCC sorry for the delay in our reply.

  1. This should be easy to change
  2. We can add a SortOrder column to the filter table and send a sorted list of filters back to the map.
    See Distance/Area tool #107 for scheduling the work

@andyb-esdm
Copy link
Collaborator

@HelenwoodsJNCC This is implemented now. We're going to discuss deployment later this afternoon with JNCC IT team.

@HelenwoodsJNCC
Copy link
Author

Hi @andyb-esdm, obviously I can't test the filter ordering but the simple apply-close functionality seems to be working fine.

@andyb-esdm
Copy link
Collaborator

@HelenwoodsJNCC Simon and I tested this 'live' (he changed the order in the database and then we refreshed the page). So we're pretty confident it works. It uses a similar mechanism to ordering the layers.
If you have any issues when staged we can fix it then - but we should be okay (famous last words ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants