Don't write into the location of the dummy pixel_indices coordinate #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jni and I talked about how
pixel_indices
incsr.py
always contains a dummy "coordinate"[0, 0]
, regardless of whether that pixel coordinate is part of the skeleton or not.@jni says it's supposed to be there in
pixel_indices
for padding, so you can directly index into it using the pixell id number. This doesn't hold if you use the defaultunique_junctions=True
kwarg, but will be the case ifunique_junctions=False
.Anyway, we shouldn't be using this dummy coordinate to write into arrays. Currently skan is overwriting a zero value with another zero, which doesn't matter much. It is confusing when you start to poke around into how we could make this work in a distributed context.