Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add versions and use pydata theme #173

Merged
merged 18 commits into from
Jun 2, 2022
Merged

DOC Add versions and use pydata theme #173

merged 18 commits into from
Jun 2, 2022

Conversation

lucyleeow
Copy link
Collaborator

uses: JamesIves/github-pages-deploy-action@4.1.5
with:
branch: gh-pages
folder: doc/_build/html
target-folder: dev
clean: true

- name: Deploy stable docs 🚀
uses: JamesIves/github-pages-deploy-action@4.1.5
if: startsWith(${{ github.ref_name }}, 'v*')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines 30 to 31
DOC_DIR="$(cut -d '.' -f 1,2 <<< "$TAG")"
echo "DOC_DIR=${DOC_DIR:1}".x >> $GITHUB_ENV
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't figure out how to make this a one liner, suggestions welcome. Works as is and outputs e.g., "0.1.x"

[
{
"version": "0.1.x",
"url": "https://jni.github.io/skan/0.1.x"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how the url's work so not sure if this works, pydata docs didn't expand. @jni can you explain..?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can replace this with skeleton-analysis.org instead of jni.github.io/skan. But I think both will work, because jni.github.io/skan/whatever.html automatically resolves to skeleton-analysis.org/whatever.html. In fact what you've got is probably the optimum choice because it'll be stable even if the domain lapses.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each of these we need to go back and build the old docs though, and the early versions are pointless. I would say let's go back to 0.7.x and no more, as that is the version matching the paper.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept jni.github.io/skan because that is what is used everywhere else in the config file. So keep as is then?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@lucyleeow
Copy link
Collaborator Author

Supposedly subsections should be in the left navigation bar by default.

but it seems to be at the top?

image

I think I have removed all alabaster config lines and hopefully it should be a default build of pydata theme now

@lucyleeow lucyleeow changed the title WIP DOC Add versions and use pydata theme DOC Add versions and use pydata theme Jun 1, 2022
@@ -133,28 +136,22 @@
'repo_url': 'https://github.com/jni/skan/',
'repo_name': 'Skan',

# Visible levels of the global TOC; -1 means unlimited
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be from alabaster theme

@lucyleeow
Copy link
Collaborator Author

I think this is ready for review and merge. I thought it would be best to get this in first before doing the branch 0.10.x, as we want the version switcher json file in gh-pages

@lucyleeow
Copy link
Collaborator Author

I've realised I need to fix version matching here.

Copy link
Owner

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🔥

@jni jni merged commit 2d8f12c into jni:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants