Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix n_points calculation (handling of 0-deg nodes) #183

Closed
wants to merge 1 commit into from
Closed

fix n_points calculation (handling of 0-deg nodes) #183

wants to merge 1 commit into from

Conversation

ssavary
Copy link

@ssavary ssavary commented Dec 2, 2022

Suggested fix for #182

@jni
Copy link
Owner

jni commented Dec 2, 2022

Thank you @ssavary! Do you think you could also add your degenerate test case to the tests?

@ssavary
Copy link
Author

ssavary commented Dec 5, 2022

Thank you @ssavary! Do you think you could also add your degenerate test case to the tests?

Ok I'll try to do it later this week.

@jni jni mentioned this pull request Jan 30, 2023
Merged
@jni
Copy link
Owner

jni commented Jan 30, 2023

@ssavary I added on top of your commit in #193 and merged, so your contribution is now in main! And this PR can be closed. Thank you again for the fix!

@jni jni closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssavary @jni @sim-sav