Adding touch control to change the display brightness #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! What do you think to turn the use of touch buttons optional through a directive? Trinity provides a facility to use the built-in touch function, but maybe they are not using Trinity, using pin 8 and 9 for other reason or they want other function for touch buttons than set bright. Let me know your opinion. |
|
Probably makes more sense to make it a boolean config setting in WiFiManager otherwise you technically would need to binaries to enable it. What do you think? |
|
Makes sense. It's works for me as well. I think the parameter could be something like "Trinity board" and soon we can add more functionalities based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.