add Response#pretty_print | Restore documented behavior #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in jnunemaker#567, the changes introduced 5a78a14 resulted in change of behavior when viewing the Response objects using command line version of the HTTParty or tools like pry. This commits adds minimal version of the #pretty_print method that behaves the same as code before, when response was inheriting from BasicObject rather than Object. This is because PP::ObjectMixin applies to Object, but it not BasicObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #567, the changes introduced 5a78a14 resulted in change of
behavior when viewing the Response objects using command line version of the
HTTParty or tools like pry.
This changs adds minimal version of the #pretty_print method that behaves the
same as code before, when response was inheriting from BasicObject rather than
Object. This is because PP::ObjectMixin applies to Object, but it not
BasicObject.
Following this commit, both CLI version of httparty and pry work correctly (as they did initially).