Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding of streamed chunk #644

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Fix encoding of streamed chunk #644

merged 4 commits into from
Feb 11, 2019

Conversation

TheSmartnik
Copy link
Collaborator

Fix #643

@jnunemaker
Copy link
Owner

@TheSmartnik Looks like a pry require failure. Probably just need the gemfile tweaked on ci to include pry. I think right now pry is only in dev.

@TheSmartnik
Copy link
Collaborator Author

@jnunemaker Thanks!

@TheSmartnik TheSmartnik force-pushed the fix_encoding_of_streamed_chunk branch from 9d4156b to 5c31276 Compare February 8, 2019 14:48
@TheSmartnik TheSmartnik force-pushed the fix_encoding_of_streamed_chunk branch from e99c6d0 to 9218784 Compare February 11, 2019 13:31
@TheSmartnik TheSmartnik merged commit 290aa62 into master Feb 11, 2019
@TheSmartnik TheSmartnik deleted the fix_encoding_of_streamed_chunk branch February 11, 2019 13:49
@TheSmartnik TheSmartnik changed the title [WIP] Fix encoding of streamed chunk Fix encoding of streamed chunk Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnunemaker jnunemaker jnunemaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSmartnik @jnunemaker