Suggestion: Replace mime-types with mini_mime for content type lookup
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mini_mime` is a minimal mime type library that's more performant and less memory hungry. https://github.com/discourse/mini_mime It has replaced `mime-types` in the `mail` gem: (which is a dependency of `actionmailer`, and by extension, `rails`) mikel/mail#1059 As well as `capybara`: teamcapybara/capybara#1884 Which also means using it as a dependency of `httparty` would be able to reuse the same dependency that should be already available in most Rails apps, instead of pulling in an extra `mime-types` dependency. The change in code is pretty straightforward, the same one made by the capybara PR linked above.
|
This is great! I'm sorry I didn't see it until now. Not sure what the deal is but I swear I'm not getting some notifications. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mini_mimeis a minimal mime type library that's more performant and less memory hungry.https://github.com/discourse/mini_mime
It has replaced
mime-typesin themailgem: (which is a dependency ofactionmailer, and by extension,rails)mikel/mail#1059
As well as
capybara:teamcapybara/capybara#1884
Which also means using it as a dependency of
httpartywould be able to reuse the same dependency that should be already available in most Rails apps, instead of pulling in an extramime-typesdependency.The change in code is pretty straightforward, the same one made by the capybara PR linked above.